Messages in this thread Patch in this message | | | From | Ben Shelton <> | Subject | [PATCH v2] checkpatch: Don't warn about returning EPOLL* defines | Date | Tue, 3 Dec 2019 12:19:48 -0600 |
| |
The EPOLL* defines are bit definitions, not errno values, so they should be returned as-is, not as negative values.
Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com> Cc: Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 592911a..67ca588 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4869,7 +4869,8 @@ sub process { # Return of what appears to be an errno should normally be negative if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) { my $name = $1; - if ($name ne 'EOF' && $name ne 'ERROR') { + if ($name ne 'EOF' && $name ne 'ERROR' && + $name !~ /EPOLL/) { WARN("USE_NEGATIVE_ERRNO", "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr); } -- 2.6.4
| |