Messages in this thread Patch in this message | | | From | Nathan Chancellor <> | Subject | [PATCH] lib/scatterlist: Adjust indentation in __sg_alloc_table | Date | Tue, 17 Dec 2019 20:36:07 -0700 |
| |
Clang warns:
../lib/scatterlist.c:314:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] return -ENOMEM; ^ ../lib/scatterlist.c:311:4: note: previous statement is here if (prv) ^ 1 warning generated.
This warning occurs because there is a space before the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.
Fixes: edce6820a9fd ("scatterlist: prevent invalid free when alloc fails") Link: https://github.com/ClangBuiltLinux/linux/issues/830 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> ---
This file doesn't seemt to have a formal maintainer but Jens seems to have a few signoffs. If not, I assume Andrew will take it.
lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/scatterlist.c b/lib/scatterlist.c index c2cf2c311b7d..5813072bc589 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -311,7 +311,7 @@ int __sg_alloc_table(struct sg_table *table, unsigned int nents, if (prv) table->nents = ++table->orig_nents; - return -ENOMEM; + return -ENOMEM; } sg_init_table(sg, alloc_size); -- 2.24.1
| |