Messages in this thread | | | From | Andreas Färber <> | Subject | [PATCH next 0/2] btrfs: Fix build warnings for arm | Date | Fri, 8 Nov 2019 22:38:51 +0100 |
| |
Hello Wenruo and Dave,
This mini-series fixes two build warnings found while cross-compiling for arm, using openSUSE's cross-arm-binutils and cross-arm-none-gcc9 packages.
Replacing BUG_ON() with btrfs_crit() error handling is noble work, but please be careful not to hardcode format specifiers for x86_64's size_t.
https://www.kernel.org/doc/Documentation/printk-formats.txt
In one case it could've been noticed during review, in another it was hidden through a macro and would've only been found through compile-testing. Probably a 32-bit i386 build would do; otherwise ARCH=arm multi_v7_defconfig plus CONFIG_BTRFS_FS should reproduce.
It's around for maybe three weeks, so I wonder why kbuild bot didn't catch it.
Cheers, Andreas
Andreas Färber (2): btrfs: tree-checker: Fix error format string btrfs: extent-tree: Fix error format string
fs/btrfs/extent-tree.c | 2 +- fs/btrfs/tree-checker.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
-- 2.16.4
| |