Messages in this thread | | | Date | Tue, 5 Nov 2019 13:41:50 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf tools: Fix time sorting |
| |
On Tue, Nov 05, 2019 at 08:49:41AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 04, 2019 at 04:48:54PM -0800, Andi Kleen escreveu: > > On Tue, Nov 05, 2019 at 12:27:11AM +0100, Jiri Olsa wrote: > > > The final sort might get confused when the comparison > > > is done over bigger numbers than int like for -s time. > > > > > > Check following report for longer workloads: > > > $ perf report -s time -F time,overhead --stdio > > > > > > Fixing hist_entry__sort to properly return int64_t and > > > not possible cut int. > > > > > > Cc: Andi Kleen <ak@linux.intel.com> > > > Link: http://lkml.kernel.org/n/tip-uetl5z1eszpubzqykvdftaq6@git.kernel.org > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > > > Looks good. > > > > Reviewed-by: Andi Kleen <ak@linux.intel.com> > > Thanks, applied after adding: > > Fixes: 043ca389a318 ("perf tools: Use hpp formats to sort final output") > Cc: stable@vger.kernel.org # v3.16+
I was wondering about putting some commit there, because it was there for long time.. but that commit you use seems to be old enough.. ;-)
thanks, jirka
| |