Messages in this thread | | | Date | Mon, 4 Nov 2019 16:48:54 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH] perf tools: Fix time sorting |
| |
On Tue, Nov 05, 2019 at 12:27:11AM +0100, Jiri Olsa wrote: > The final sort might get confused when the comparison > is done over bigger numbers than int like for -s time. > > Check following report for longer workloads: > $ perf report -s time -F time,overhead --stdio > > Fixing hist_entry__sort to properly return int64_t and > not possible cut int. > > Cc: Andi Kleen <ak@linux.intel.com> > Link: http://lkml.kernel.org/n/tip-uetl5z1eszpubzqykvdftaq6@git.kernel.org > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Looks good.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
| |