Messages in this thread Patch in this message | | | Date | Thu, 28 Nov 2019 21:02:03 +0530 | From | Amol Grover <> | Subject | [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer |
| |
add __rcu notation to RCU protected global pointer auditd_conn
Fixes multiple instances of sparse error: error: incompatible types in comparison expression (different address spaces)
Signed-off-by: Amol Grover <frextrite@gmail.com> --- v2: - fix erroneous RCU pointer initialization
kernel/audit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/audit.c b/kernel/audit.c index da8dc0db5bd3..ff7cfc61f53d 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -102,12 +102,13 @@ struct audit_net { * This struct is RCU protected; you must either hold the RCU lock for reading * or the associated spinlock for writing. */ -static struct auditd_connection { +struct auditd_connection { struct pid *pid; u32 portid; struct net *net; struct rcu_head rcu; -} *auditd_conn = NULL; +}; +static struct auditd_connection __rcu *auditd_conn; static DEFINE_SPINLOCK(auditd_conn_lock); /* If audit_rate_limit is non-zero, limit the rate of sending audit records -- 2.24.0
| |