Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 23 Oct 2019 10:34:16 +0200 | Subject | Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API |
| |
Hi Andy,
On Wed, Oct 23, 2019 at 10:01 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Tue, Oct 22, 2019 at 08:03:00PM +0200, Geert Uytterhoeven wrote: > > On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > Instead of customized approach convert the driver to use bitmap API. > > > > #define MAX_BANK 5 > > > #define BANK_SZ 8 > > > +#define MAX_LINE (MAX_BANK * BANK_SZ) > > > > Given (almost) everything is now bitmap (i.e. long [])-based, you might > > as well increase MAX_BANK to a multiple of 4 or 8, e.g. 8. > > We can do it any time when we will really need it.
True. Especially as there's no real need to do it now. (sorry, my mind mixed this up with gpio-74x164...)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |