Messages in this thread | | | Date | Wed, 23 Oct 2019 11:01:09 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API |
| |
On Tue, Oct 22, 2019 at 08:03:00PM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > Instead of customized approach convert the driver to use bitmap API.
> > #define MAX_BANK 5 > > #define BANK_SZ 8 > > +#define MAX_LINE (MAX_BANK * BANK_SZ) > > Given (almost) everything is now bitmap (i.e. long [])-based, you might > as well increase MAX_BANK to a multiple of 4 or 8, e.g. 8.
We can do it any time when we will really need it.
(Yes, I understand that we have no penalty for the change anyway)
-- With Best Regards, Andy Shevchenko
| |