Messages in this thread Patch in this message | | | From | Bernhard Gebetsberger <> | Subject | [PATCH] xhci: Don't use soft retry if slot id > 0 | Date | Sun, 13 Oct 2019 02:33:13 +0200 |
| |
According to the xhci specification(chapter 4.6.8.1) soft retry shouldn't be used if the slot id is higher than 0. Currently some usb devices break on some systems because soft retry is being used when there is a transaction error, without checking the slot id.
Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors")
Signed-off-by: Bernhard Gebetsberger <bernhard.gebetsberger@gmx.at> --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 85ceb43e3405..5fa06189068d 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -2270,7 +2270,7 @@ static int process_bulk_intr_td(struct xhci_hcd *xhci, struct xhci_td *td, break; case COMP_USB_TRANSACTION_ERROR: if ((ep_ring->err_count++ > MAX_SOFT_RETRY) || - le32_to_cpu(slot_ctx->tt_info) & TT_SLOT) + le32_to_cpu(slot_ctx->tt_info) & TT_SLOT || slot_id > 0) break; *status = 0; xhci_cleanup_halted_endpoint(xhci, slot_id, ep_index, -- 2.23.0
| |