Messages in this thread | | | From | Markus Elfring <> | Subject | clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll() | Date | Sat, 12 Oct 2019 15:55:44 +0200 |
| |
Hello,
I tried another script for the semantic patch language out. This source code analysis approach points out that the implementation of the function “rockchip_clk_register_pll” contains also a call of the function “kmemdup”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/rockchip/clk-pll.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n913 https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/rockchip/clk-pll.c#L913
* Do you find the usage of the format string “%s: could not allocate rate table for %s\n” still appropriate at this place?
* Is there a need to adjust the error handling here?
Regards, Markus
| |