lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
From
Date
Hi Peter,

Am 17.01.19 um 08:01 schrieb Peter Chen:
>
>>
>> The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity
>> depends on the board. Reset state of the polarity is low-active so add this property
>> to allow it to be high-active.
>>
>
> As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers)
> work like this, and most of them are low active for PP default. Would you just use "i.mx" at
> both your code and your comment?

Am i right that i have to add my code block to (nearly) all other version specific init functions then?
Will do so in next days and then send a v4 of this patch.
>
> Peter
>
>> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
>> ---
>> Changes in v3: add description
>> ---
>> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> index adae82385dd6..8696e3eff6e7 100644
>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> @@ -93,6 +93,7 @@ i.mx specific properties
>> - over-current-active-low: over current signal polarity is active low.
>> - over-current-active-high: over current signal polarity is active high.
>> It's recommended to specify the over current polarity.
>> +- power-active-high: power signal polarity is high active (only for
>> +imx6q/dl)
>> - external-vbus-divider: enables off-chip resistor divider for Vbus
>>
>> Example:
>> --
>> 2.20.1
>

\
 
 \ /
  Last update: 2019-01-21 19:07    [W:0.086 / U:31.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site