Messages in this thread Patch in this message | | | From | Nathan Chancellor <> | Subject | [PATCH] staging: rtl8723bs: Remove ACPI table declaration | Date | Tue, 25 Sep 2018 22:39:10 -0700 |
| |
Clang warns that the acpi_id declaration is not going to be emitted in the final assembly:
drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable 'acpi_ids' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct acpi_device_id acpi_ids[] = { ^ 1 warning generated.
This is because it's marked as static const and it is not used anywhere in this file. Doing a git grep on this driver for 'acpi' shows that this declaration has been unused since the driver's initial induction. Remove it since it's not doing anything.
Link: https://github.com/ClangBuiltLinux/linux/issues/169 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 6d02904de63f..d473f9bd08c3 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -22,13 +22,7 @@ static const struct sdio_device_id sdio_ids[] = { SDIO_DEVICE(0x024c, 0xb723), }, { /* end: all zeroes */ }, }; -static const struct acpi_device_id acpi_ids[] = { - {"OBDA8723", 0x0000}, - {} -}; - MODULE_DEVICE_TABLE(sdio, sdio_ids); -MODULE_DEVICE_TABLE(acpi, acpi_ids); static int rtw_drv_init(struct sdio_func *func, const struct sdio_device_id *id); static void rtw_dev_remove(struct sdio_func *func); -- 2.19.0
| |