lkml.org 
[lkml]   [2018]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
Date
John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call
ieee80211_networks_free(). In addition, that function has an un-needed check
before kfree().

Reported-by: John Whitmore <arigead@gmail.com>
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 90a097f2cd4e..97ff0371b5bb 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -78,8 +78,6 @@ static inline int ieee80211_networks_allocate(struct ieee80211_device *ieee)

static inline void ieee80211_networks_free(struct ieee80211_device *ieee)
{
- if (!ieee->networks)
- return;
kfree(ieee->networks);
ieee->networks = NULL;
}
@@ -180,6 +178,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
return dev;

failed:
+ ieee80211_networks_free(ieee);
if (dev)
free_netdev(dev);

\
 
 \ /
  Last update: 2018-09-26 19:53    [W:0.052 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site