lkml.org 
[lkml]   [2018]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/8] x86/mm/cpa: Move flush_tlb_all()
From
Date
On 09/19/2018 01:50 AM, Peter Zijlstra wrote:
> @@ -1528,28 +1538,8 @@ static int __change_page_attr(struct cpa
> * We have to split the large page:
> */
> err = split_large_page(cpa, kpte, address);
> - if (!err) {
...
> - flush_tlb_all();
> + if (!err)
> goto repeat;
> - }

I _think_ this is the only use of split_large_page()'s error code. We
can just make it return void now, right?

BTW, I also really like doing the "final" TLB flush as close as possible
to the actual PTE manipulation. Makes it much less likely that we break it.

\
 
 \ /
  Last update: 2018-09-21 23:36    [W:0.223 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site