Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 5 Aug 2018 13:26:20 +0300 | Subject | Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values |
| |
On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > Return statements in functions returning bool should use true or false > instead of an integer value. > > This code was detected with the help of Coccinelle.
> static bool has_cap(u32 cap) > { > if ((interface->capability & cap) != 0) > - return 1; > + return true; > > - return 0; > + return false; > }
this entire function can be oneliner:
return !!(...);
-- With Best Regards, Andy Shevchenko
| |