lkml.org 
[lkml]   [2018]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] platform/x86: acer-wmi: use true and false for boolean values
On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This code was detected with the help of Coccinelle.

> static bool has_cap(u32 cap)
> {
> if ((interface->capability & cap) != 0)
> - return 1;
> + return true;
>
> - return 0;
> + return false;
> }

this entire function can be oneliner:

return !!(...);


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-08-05 12:27    [W:0.052 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site