Messages in this thread | | | Subject | Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values | From | "Gustavo A. R. Silva" <> | Date | Mon, 6 Aug 2018 12:24:26 -0500 |
| |
On 08/06/2018 11:42 AM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +0000, David Laight wrote: >> From: Andy Shevchenko >>> Sent: 05 August 2018 11:26 >>> >>> On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva >>> <gustavo@embeddedor.com> wrote: >>>> Return statements in functions returning bool should use true or false >>>> instead of an integer value. >>>> >>>> This code was detected with the help of Coccinelle. >>>> static bool has_cap(u32 cap) >>>> { >>>> if ((interface->capability & cap) != 0) >>>> - return 1; >>>> + return true; >>>> >>>> - return 0; >>>> + return false; >>>> } >>> >>> this entire function can be oneliner: >>> >>> return !!(...); >> >> Why the !! ?? Just: >> return (interface->capability & cap) != 0; > > Because the return is bool you don't need the !! either. > The compiler does that. >
Hi all,
I'll send v2 with the suggested improvements.
Thanks for your feedback. -- Gustavo
| |