lkml.org 
[lkml]   [2018]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH v6 0/3] staging: mt7621-mmc: Fix debug macros and their usages
This patchset fixes the three debug macros N_MSG, ERR_MSG, and
IRQ_MSG. Each patch fixes one particular macro and its usages.

For N_MSG, deletes the macro and its users as it is a no-op.

For ERR_MSG and IRQ_MSG, replaces printk with dev_<level> without __func__ or
__LINE__ or current->comm and current->pid. Removes the do {} while(0) loop
for the single statement macro. Further drops the macros and replaces their
usages with dev_<level>. Deletes the commented usages.

Changes in v6:
- Delete N_MSG() macro and its users as it is a no-op.
- Patchset reduced to 3 patches as the patch INIT_MSG patch is accepted.

Changes in v5:
- Remove commented code for N_MSG().
- Remove commented ERR_MSG() usages.

Changes in v4:
- Create multiple patches, one for each type of macro being
deleted/changed.

Changes in v3:
- Replace usages of ERR_MSG and IRQ_MSG with dev_err() in code itself.
- Remove all INIT_MSG usages.
- Drop ERR_MSG, INIT_MSG and IRQ_MSG from dbg.h.

Changes in v2:
- Replace printk with dev_<level>.
- Remove __func__, __LINE__, current->comm, current->pid from arguments.
- Remove the do {} while(0) loop from these macros.
- Modify commit message to include other changes.

Nishad Kamdar (3):
staging: mt7621-mmc: Delete N_MSG() and all its users
staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages
staging: mt7621-mmc: Fix debug macro IRQ_MSG and its usages

drivers/staging/mt7621-mmc/dbg.h | 28 ---
drivers/staging/mt7621-mmc/sd.c | 398 +++++++++----------------------
2 files changed, 108 insertions(+), 318 deletions(-)

--
2.17.1

\
 
 \ /
  Last update: 2018-09-01 00:13    [W:0.788 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site