Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] net: ethernet: sun: remove redundant variables adv and lpa | Date | Thu, 5 Jul 2018 10:37:32 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Variables adv and lpa are being assigned but are never used hence they are redundant and can be removed.
Cleans up clang warnings: warning: variable 'lpa' set but not used [-Wunused-but-set-variable] warning: variable 'adv' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/net/ethernet/sun/niu.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 88c12474a0c3..2d6b62c6d9ab 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -1225,17 +1225,13 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p) bmsr = err; if (bmsr & BMSR_LSTATUS) { - u16 adv, lpa; - err = mii_read(np, np->phy_addr, MII_ADVERTISE); if (err < 0) goto out; - adv = err; err = mii_read(np, np->phy_addr, MII_LPA); if (err < 0) goto out; - lpa = err; err = mii_read(np, np->phy_addr, MII_ESTATUS); if (err < 0) -- 2.17.1
| |