Messages in this thread Patch in this message | | | Date | Fri, 23 Mar 2018 14:37:36 +0300 | From | Dan Carpenter <> | Subject | [PATCH] tracing: Fix a potential NULL dereference |
| |
We forgot to set the error code on this path so we return ERR_PTR(0) which is NULL. It results in a NULL dereference in the caller.
Fixes: 100719dcef44 ("tracing: Add simple expression support to hist triggers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 4f027642ceef..a02bc09d765a 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -2776,6 +2776,7 @@ static struct hist_field *parse_expr(struct hist_trigger_data *hist_data, expr->fn = hist_field_plus; break; default: + ret = -EINVAL; goto free; }
| |