Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 6 Dec 2018 10:30:32 -0800 | Subject | Re: [RFC] avoid indirect calls for DMA direct mappings |
| |
On Thu, Dec 6, 2018 at 10:28 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Put another way, you made the fast case unnecessarily slow.
Side note: the code seems to be a bit confused about it, because *some* cases test the fast case first, and some do it after they've already accessed the pointer for the slow case.
So even aside from the performance and code generation issue (and possible future "use a special bit pattern for the fast case"), it would be good for _consistency_ to just always do the fast-case test first.
Linus
| |