Messages in this thread | | | Date | Thu, 6 Dec 2018 15:52:44 +0000 | From | Will Deacon <> | Subject | Re: [PATCH] scripts/atomic: change 'fold' to 'grep' |
| |
[+ Ingo and Mark]
On Tue, Dec 04, 2018 at 10:47:13PM +0100, Anders Roxell wrote: > Some distibutions and build systems doesn't include 'fold' from > coreutils default. > > .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found > > Rework to use 'grep' instead of 'fold' to use a dependency that is > already used a lot in the kernel. > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Suggested-by: Will Deacon <will.deacon@arm.com> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > scripts/atomic/atomic-tbl.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh > index 9d6be538a987..81d5c32039dd 100755 > --- a/scripts/atomic/atomic-tbl.sh > +++ b/scripts/atomic/atomic-tbl.sh > @@ -180,7 +180,7 @@ gen_proto_variants() > #gen_proto(meta, ...) > gen_proto() { > local meta="$1"; shift > - for m in $(echo "${meta}" | fold -w1); do > + for m in $(echo "${meta}" | grep -o .); do > gen_proto_variants "${m}" "$@" > done
Acked-by: Will Deacon <will.deacon@arm.com>
Ingo -- please can you take this one via -tip?
Cheers,
Will
| |