lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scripts/atomic: change 'fold' to 'grep'

* Will Deacon <will.deacon@arm.com> wrote:

> [+ Ingo and Mark]
>
> On Tue, Dec 04, 2018 at 10:47:13PM +0100, Anders Roxell wrote:
> > Some distibutions and build systems doesn't include 'fold' from
> > coreutils default.
> >
> > .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
> >
> > Rework to use 'grep' instead of 'fold' to use a dependency that is
> > already used a lot in the kernel.
> >
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Suggested-by: Will Deacon <will.deacon@arm.com>
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > scripts/atomic/atomic-tbl.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> > index 9d6be538a987..81d5c32039dd 100755
> > --- a/scripts/atomic/atomic-tbl.sh
> > +++ b/scripts/atomic/atomic-tbl.sh
> > @@ -180,7 +180,7 @@ gen_proto_variants()
> > #gen_proto(meta, ...)
> > gen_proto() {
> > local meta="$1"; shift
> > - for m in $(echo "${meta}" | fold -w1); do
> > + for m in $(echo "${meta}" | grep -o .); do
> > gen_proto_variants "${m}" "$@"
> > done
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Ingo -- please can you take this one via -tip?

I'm still waiting for a reply to my previous concerns expressed in:

Re: [tip:locking/core] locking/atomics: Check generated headers are up-to-date
<20181128083057.GA7879@gmail.com>

Will remove it from linux-next if there's no good resolution for this
cycle.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-12-06 17:15    [W:0.036 / U:28.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site