lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 16/19] mailbox: qcom-apcs: Use device-managed registration API
On Mon 17 Dec 07:02 PST 2018, Thierry Reding wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Georgi Djakov <georgi.djakov@linaro.org>
> Cc: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index aed23ac9550d..3cf2937be149 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -91,7 +91,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> apcs->mbox.chans = apcs->mbox_chans;
> apcs->mbox.num_chans = ARRAY_SIZE(apcs->mbox_chans);
>
> - ret = mbox_controller_register(&apcs->mbox);
> + ret = devm_mbox_controller_register(&pdev->dev, &apcs->mbox);
> if (ret) {
> dev_err(&pdev->dev, "failed to register APCS IPC controller\n");
> return ret;
> @@ -115,7 +115,6 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev)
> struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev);
> struct platform_device *clk = apcs->clk;
>
> - mbox_controller_unregister(&apcs->mbox);
> platform_device_unregister(clk);
>
> return 0;
> --
> 2.19.1
>

\
 
 \ /
  Last update: 2018-12-17 19:16    [W:0.368 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site