lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 17/19] mailbox: rockchip: Use device-managed registration API
    Date
    From: Thierry Reding <treding@nvidia.com>

    Get rid of some boilerplate driver removal code by using the newly added
    device-managed registration API.

    Cc: Caesar Wang <wxt@rock-chips.com>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    ---
    drivers/mailbox/rockchip-mailbox.c | 15 +--------------
    1 file changed, 1 insertion(+), 14 deletions(-)

    diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c
    index d702a204f5c1..f24a77b1a0ff 100644
    --- a/drivers/mailbox/rockchip-mailbox.c
    +++ b/drivers/mailbox/rockchip-mailbox.c
    @@ -247,28 +247,15 @@ static int rockchip_mbox_probe(struct platform_device *pdev)
    mb->chans[i].msg = NULL;
    }

    - ret = mbox_controller_register(&mb->mbox);
    + ret = devm_mbox_controller_register(&pdev->dev, &mb->mbox);
    if (ret < 0)
    dev_err(&pdev->dev, "Failed to register mailbox: %d\n", ret);

    return ret;
    }

    -static int rockchip_mbox_remove(struct platform_device *pdev)
    -{
    - struct rockchip_mbox *mb = platform_get_drvdata(pdev);
    -
    - if (!mb)
    - return -EINVAL;
    -
    - mbox_controller_unregister(&mb->mbox);
    -
    - return 0;
    -}
    -
    static struct platform_driver rockchip_mbox_driver = {
    .probe = rockchip_mbox_probe,
    - .remove = rockchip_mbox_remove,
    .driver = {
    .name = "rockchip-mailbox",
    .of_match_table = of_match_ptr(rockchip_mbox_of_match),
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-17 16:03    [W:4.095 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site