Messages in this thread | | | Subject | Re: [driver-core PATCH v5 2/9] async: Add support for queueing on specific NUMA node | From | Bart Van Assche <> | Date | Tue, 06 Nov 2018 16:50:29 -0800 |
| |
On Mon, 2018-11-05 at 13:11 -0800, Alexander Duyck wrote: > +/** > + * async_schedule_domain - schedule a function for asynchronous execution within a certain domain > + * @func: function to execute asynchronously > + * @data: data pointer to pass to the function > + * @domain: the domain > + * > + * Returns an async_cookie_t that may be used for checkpointing later. > + * @domain may be used in the async_synchronize_*_domain() functions to > + * wait within a certain synchronization domain rather than globally. A > + * synchronization domain is specified via @domain. > + * Note: This function may be called from atomic or non-atomic contexts. > + */
Please leave out "A synchronization domain is specified via @domain." since that text is redundant due to "@domain: the domain".
> +/** > + * async_schedule_dev_domain - A device specific version of async_schedule_domain > + * @func: function to execute asynchronously > + * @dev: device argument to be passed to function > + * @domain: the domain > + * > + * Returns an async_cookie_t that may be used for checkpointing later. > + * @dev is used as both the argument for the function and to provide NUMA > + * context for where to run the function. By doing this we can try to > + * provide for the best possible outcome by operating on the device on the > + * CPUs closest to the device. > + * @domain may be used in the async_synchronize_*_domain() functions to > + * wait within a certain synchronization domain rather than globally. A > + * synchronization domain is specified via @domain. > + * Note: This function may be called from atomic or non-atomic contexts. > + */
Same comment here: I think "A synchronization domain is specified via @domain." is redundant.
> +/** > + * async_schedule_node_domain - NUMA specific version of async_schedule_domain > + * @func: function to execute asynchronously > + * @data: data pointer to pass to the function > + * @node: NUMA node that we want to schedule this on or close to > + * @domain: the domain > + * > + * Returns an async_cookie_t that may be used for checkpointing later. > + * @domain may be used in the async_synchronize_*_domain() functions to > + * wait within a certain synchronization domain rather than globally. A > + * synchronization domain is specified via @domain. Note: This function > + * may be called from atomic or non-atomic contexts. > + * > + * The node requested will be honored on a best effort basis. If the node > + * has no CPUs associated with it then the work is distributed among all > + * available CPUs. > + */
Same comment here: I think that also in the above "A synchronization domain is specified via @domain." is redundant.
Otherwise this patch looks fine to me.
Bart.
| |