lkml.org 
[lkml]   [2018]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [driver-core PATCH v5 1/9] workqueue: Provide queue_work_node to queue work near a given NUMA node
From
Date
On Mon, 2018-11-05 at 16:42 -0800, Bart Van Assche wrote:
> On Mon, 2018-11-05 at 13:11 -0800, Alexander Duyck wrote:
> > +/**
> > + * workqueue_select_cpu_near - Select a CPU based on NUMA node
> > + * @node: NUMA node ID that we want to bind a CPU from
>
> ^^^^
> select?
> > + /* If CPU is valid return that, otherwise just defer */
> > + return (cpu < nr_cpu_ids) ? cpu : WORK_CPU_UNBOUND;
>
> Please leave out the superfluous parentheses if this patch series would have to
> be reposted.
>
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

I will incorporate you suggestions and add your Reviewed-by for the
next submission.

Thanks.

- Alex

\
 
 \ /
  Last update: 2018-11-06 17:28    [W:0.114 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site