Messages in this thread | | | Date | Fri, 30 Nov 2018 12:06:52 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper |
| |
> > > drivers/i2c/i2c-core-acpi.c | 41 ++++++++++++++++++++++++++----------- > > > include/linux/acpi.h | 11 ++++++++++ > > > > Any reason this is not in i2c.h? > > Yes. As I explained earlier to some people there are facts affecting this: > - the function is operate on top of solely ACPI structures
And moving the function itself to the ACPI realm then?
I don't say this is a show-stopper for this series, but I just wonder...
> - there is already similar function for GPIO and it stays like that > > On top of this recently I've discovered, that i2c.h has separate #ifdef for I2C > and ACPI which theoretically might produce a linker error in some cases.
Is this something we have to live with or which can be cleaned up somewhen?
[unhandled content-type:application/pgp-signature]
| |