Messages in this thread | | | Date | Fri, 30 Nov 2018 12:57:59 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper |
| |
On Fri, Nov 30, 2018 at 10:55:33AM +0100, Wolfram Sang wrote: > On Wed, Nov 28, 2018 at 01:45:29PM +0200, Andy Shevchenko wrote: > > Besides current two users one more is coming. Definitely makes sense to > > introduce a helper. > > > > No functional change intended. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > --- > > drivers/i2c/i2c-core-acpi.c | 41 ++++++++++++++++++++++++++----------- > > include/linux/acpi.h | 11 ++++++++++ > > Any reason this is not in i2c.h?
Yes. As I explained earlier to some people there are facts affecting this: - the function is operate on top of solely ACPI structures - there is already similar function for GPIO and it stays like that
On top of this recently I've discovered, that i2c.h has separate #ifdef for I2C and ACPI which theoretically might produce a linker error in some cases.
-- With Best Regards, Andy Shevchenko
| |