lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH] drm: Rename crtc_idr as object_idr to KMS cleanups
On 10/31, Julia Lawall wrote:
>
>
> On Wed, 31 Oct 2018, Shayenne da Luz Moura wrote:
>
> > Rename 'drm_mode_config.crtc_idr' as 'drm_mode_config.object_idr',
> > as proposed in the task description in TODO list for KMS cleanups.
>
> Is object_idr a field that already exists? If so, "Rename" is not the
> best choice of words. It should be something like "use the object_idr
> field instead of the crtc_idr field" and then explain why. "task
> description in TODO list for KMS cleanups" isn't very helpful to
> understand why the change should be made.
>
> julia

Hi Julia,

Thank you for your review!

This patch is to solve this TODO task:
drm_mode_config.crtc_idr is misnamed, since it contains all KMS object.
Should be renamed to drm_mode_config.object_idr.

Do you think I need to use this description in my commit message?

Best,
Shayenne

\
 
 \ /
  Last update: 2018-10-31 22:20    [W:0.079 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site