Messages in this thread | | | From | Emil Velikov <> | Date | Wed, 31 Oct 2018 23:28:59 +0000 | Subject | Re: [PATCH] drm: Rename crtc_idr as object_idr to KMS cleanups |
| |
Hi Shayenne,
Welcome to DRM.
As far as I can see you're a newcomer to kernel development, so I'd recommend watch a recent talk from Marc [1] He provides a very good introduction, both for newbies and for people willing the know the deeper reasons behind.
That said, here's some suggestions:
On Wed, 31 Oct 2018 at 20:58, Shayenne da Luz Moura <shayenneluzmoura@gmail.com> wrote: > I'd rename the title to "drm: rename drm_mode_config::crtc_idr to object_idr" The "... as ... to KMS cleanups" translation is very strange in English. It confused me and I've read the TODO over a dozen times ;-)
> Rename 'drm_mode_config.crtc_idr' as 'drm_mode_config.object_idr', > as proposed in the task description in TODO list for KMS cleanups. > Similarly here.
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com> > --- > drivers/gpu/drm/drm_lease.c | 6 +++--- > drivers/gpu/drm/drm_mode_config.c | 4 ++-- > drivers/gpu/drm/drm_mode_object.c | 8 ++++---- > 3 files changed, 9 insertions(+), 9 deletions(-) > As pointed out in the talk - always self review and ensure patches don't break things. Here, DRM doesn't build which is obviously not correct and breaks things.
HTH Emil [1] https://www.youtube.com/watch?v=LIdznotOxvg
| |