lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee
On Tue, Aug 01, 2017 at 04:32:37PM -0400, Vivien Didelot wrote:
> It is safer to init the EEE before the DSA layer call
> phy_ethtool_set_eee, as sf2 and qca8k are doing.

I can understand making all the drivers do the same thing, but the
next patch deletes this change, making is pointless.

My preference would be to drop this. But it is not a strong preference.

Andrew

\
 
 \ /
  Last update: 2017-08-01 23:03    [W:0.082 / U:4.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site