Messages in this thread | | | Date | Mon, 17 Jul 2017 07:09:34 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH 2/4] fs/dcache: Report negative dentry number in dentry-state |
| |
On Mon, Jul 17, 2017 at 09:39:31AM -0400, Waiman Long wrote: > @@ -63,9 +63,10 @@ struct qstr { > struct dentry_stat_t { > long nr_dentry; > long nr_unused; > - long age_limit; /* age in seconds */ > - long want_pages; /* pages requested by system */ > - long dummy[2]; > + long nr_negative; /* # of negative dentries */ > + long age_limit; /* age in seconds */ > + long want_pages; /* pages requested by system */ > + long dummy; > }; > extern struct dentry_stat_t dentry_stat;
You can't just insert a field in the middle like that. It'll break any code parsing /proc/sys/fs/dentry-state. You have to put it at the end:
long age_limit; /* age in seconds */ long want_pages; /* pages requested by system */ - long dummy[2]; + long nr_negative; /* # of negative dentries */ + long dummy; };
| |