Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 1/2 v2] leds: tlc591xx: merge conditional tests | Date | Sat, 15 Jul 2017 11:58:18 +0200 |
| |
Merge conditionals that have the same then branch, to prepare for extending that branch with of_node_put.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/leds/leds-tlc591xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c index 30453164..fcc87ee 100644 --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -232,9 +232,8 @@ struct tlc591xx { err = of_property_read_u32(child, "reg", ®); if (err) return err; - if (reg < 0 || reg >= tlc591xx->max_leds) - return -EINVAL; - if (priv->leds[reg].active) + if (reg < 0 || reg >= tlc591xx->max_leds || + priv->leds[reg].active) return -EINVAL; priv->leds[reg].active = true; priv->leds[reg].ldev.name =
| |