Messages in this thread | | | Date | Wed, 28 Jun 2017 18:21:28 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| |
On Mon, Jun 26, 2017 at 02:29:35PM -0500, Eddie James wrote: > From: "Edward A. James" <eajames@us.ibm.com>
"dt-bindings: i2c: ..." for the subject.
> > Document the bindings. > > Signed-off-by: Edward A. James <eajames@us.ibm.com> > --- > Documentation/devicetree/bindings/i2c/i2c-fsi.txt | 31 +++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt > new file mode 100644 > index 0000000..fffc067 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt > @@ -0,0 +1,31 @@ > +Device-tree bindings for FSI-attached I2C master driver > +------------------------------------------------------- > + > +Required properties: > + - compatible = "ibm,i2cm-fsi";
Only one version?
> + - reg = < address size >; : The FSI CFAM address and address space > + size. > + - #address-cells = <1>; : Number of address cells in child nodes > + - #size-cells = <0>; : Number of size cells in child nodes. > + - child nodes : Nodes to describe ports off the I2C > + master. > + > +Child node required properties: > + - reg = < port number > : The port number on the I2C master. > + > +Examples: > + > + i2cm@1800 {
i2c@1800
> + compatible = "ibm,i2cm-fsi"; > + reg = < 0x1800 0x400 >; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 {
The ports are separate i2c buses? Use i2c-bus@... instead. "ports" is already used by OF graph binding.
> + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > -- > 1.8.3.1 >
| |