lkml.org 
[lkml]   [2017]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Hi Joel,

>> +static ssize_t external_mode_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + struct fsi_master_gpio *master = dev_get_drvdata(dev);
>> +
>> + return snprintf(buf, PAGE_SIZE - 1, "%u",
>
> I gave this a spin on a machine today and noticed we're missing a
> newline there. Should this be "%u\n"?

Yep, that'd make things easier to read. v2 coming.

Cheers,


Jeremy

\
 
 \ /
  Last update: 2017-06-22 19:59    [W:0.058 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site