Messages in this thread | | Hi Joel,
>> +static ssize_t external_mode_show(struct device *dev, >> + struct device_attribute *attr, char *buf) >> +{ >> + struct fsi_master_gpio *master = dev_get_drvdata(dev); >> + >> + return snprintf(buf, PAGE_SIZE - 1, "%u", > > I gave this a spin on a machine today and noticed we're missing a > newline there. Should this be "%u\n"?
Yep, that'd make things easier to read. v2 coming.
Cheers,
Jeremy
| |