lkml.org 
[lkml]   [2017]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] fsi/master-gpio: Add external mode
Hi Jeremy,

On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr <jk@ozlabs.org> wrote:
> This change introduces an 'external mode' for GPIO-based FSI masters,
> +static ssize_t external_mode_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct fsi_master_gpio *master = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE - 1, "%u",

I gave this a spin on a machine today and noticed we're missing a
newline there. Should this be "%u\n"?

Cheers,

Joel

> + master->external_mode ? 1 : 0);
> +}
> +

\
 
 \ /
  Last update: 2017-06-21 08:01    [W:0.104 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site