Messages in this thread | | | Date | Fri, 19 May 2017 09:15:58 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style |
| |
On Fri, May 19, 2017 at 12:33:11PM +0530, surenderpolsani@gmail.com wrote: > From: Surender Polsani <surenderpolsani@gmail.com> > > Fixed the following checkpatch.pl warnings: > octal permissions are more preferable than symbolic permissions > > Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family > as suggested by Greg K-H. Changed attributes and function > names where ever required to satisfy internal macro definitions > like __ATTR__RW().
No you did not:
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR, > +static DEVICE_ATTR(power_state, 0644, > tsl2x7x_power_state_show, tsl2x7x_power_state_store);
???
Wrong patch?
| |