Messages in this thread | | | Date | Fri, 19 May 2017 10:20:41 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style |
| |
On Fri, May 19, 2017 at 01:42:55PM +0530, surenderpolsani@gmail.com wrote: > -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR, > - tsl2x7x_power_state_show, tsl2x7x_power_state_store); > +static DEVICE_ATTR_RW(tsl2x7x_power_state);
You do realize you just renamed the sysfs file, changing the user/kernel api? That's generally not a good thing to ever do :(
thanks,
greg k-h
| |