Messages in this thread | | | Date | Sat, 8 Apr 2017 17:07:17 +0100 | From | Alfonso Lima <> | Subject | [bug report] checkpatch: if statement does not need to be enclosed in parentheses |
| |
Hi,
In current linux-next, if you run the script on this piece of code:
#define FOO(a) \ if (a) { \ something(); \ something_else(); \ }
You should get:
ERROR: Macros with complex values should be enclosed in parentheses #1: FILE: foo.c:1: +#define FOO(a) \ + if (a) { \ + something(); \ + something_else(); \ + }
We could silence checkpatch.pl using "do {} while ()" around the if statement. However, the "if () {}" statement should be enough. If someone could confirm this, I'll go and fix it.
Thanks, Alfonso
| |