lkml.org 
[lkml]   [2017]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] firmware: Google VPD: Fix return value check in vpd_platform_init()
Date
From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function platform_device_register_simple()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/firmware/google/vpd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index 619f4ba..3ce8131 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -303,8 +303,8 @@ static int __init vpd_platform_init(void)
struct platform_device *pdev;

pdev = platform_device_register_simple("vpd", -1, NULL, 0);
- if (!pdev)
- return -ENODEV;
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);

vpd_kobj = kobject_create_and_add("vpd", firmware_kobj);
if (!vpd_kobj)
\
 
 \ /
  Last update: 2017-04-26 15:48    [W:0.984 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site