Messages in this thread Patch in this message | | | From | Pan Bian <> | Subject | [PATCH 1/1] scsi: esas2r: fix unchecked return value | Date | Sun, 23 Apr 2017 13:32:39 +0800 |
| |
Function pci_enable_device() returns a negative errno on failure, and its return value should be validated. In function esas2r_resume(), its return value is ignored. This patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com> --- drivers/scsi/esas2r/esas2r_init.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c index 6432a50..f482664 100644 --- a/drivers/scsi/esas2r/esas2r_init.c +++ b/drivers/scsi/esas2r/esas2r_init.c @@ -728,6 +728,8 @@ int esas2r_resume(struct pci_dev *pdev) esas2r_log_dev(ESAS2R_LOG_INFO, &(pdev->dev), "pci_enable_device() called"); rez = pci_enable_device(pdev); + if (rez) + goto error_exit; pci_set_master(pdev); if (!a) { -- 1.9.1
| |