Messages in this thread | | | Subject | Re: [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver | From | Jarkko Nikula <> | Date | Thu, 20 Apr 2017 15:49:01 +0300 |
| |
On 04/12/2017 07:47 PM, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were transformed > in a single driver. > - Common definitions were moved to i2c-designware-core.h > - The i2c-designware-core is now only a library file, the functions > associated are in a source file called i2c-designware-common and > are used by both i2c-designware-master and i2c-designware-slave. > - To decrease noise in namespace common i2c_dw_*() functions are > now using ops to keep them private. > - Designware PCI driver had to be changed to match the previous ops > functions implementation. > > Almost all of the "core" source is now part of the "master" source. The > difference is the functions used by both modes and they are in the > "common" source file. > > Signed-off-by: Luis Oliveira <lolivei@synopsys.com> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v7-v8 > - removed "@dynamic_tar_update_enabled" comment > > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-designware-common.c | 274 +++++++++++++++ > drivers/i2c/busses/i2c-designware-core.h | 145 +++++++- > ...c-designware-core.c => i2c-designware-master.c} | 367 +-------------------- > drivers/i2c/busses/i2c-designware-pcidrv.c | 8 +- > drivers/i2c/busses/i2c-designware-platdrv.c | 6 +- > 6 files changed, 432 insertions(+), 369 deletions(-) > create mode 100644 drivers/i2c/busses/i2c-designware-common.c > rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (65%) > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
| |