Messages in this thread | | | Date | Sun, 2 Apr 2017 19:29:49 +0200 | From | Andreas Klinger <> | Subject | Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation |
| |
Linus Walleij <linus.walleij@linaro.org> schrieb am Sun, 02. Apr 16:56: > On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote: > > On 27/03/17 11:06, Andreas Klinger wrote: > >> While calculating the compensation of the humidity there are negative > >> values interpreted as unsigned because of unsigned variables used. > >> These values need to be casted to signed as indicated by the documentation > >> of the sensor. > >> > >> Signed-off-by: Andreas Klinger <ak@it-klinger.de> > > > > Looks superficially right to me, but would like an Ack from Linus Walleij. > > I didn't work on these calculations, only infrastructure for the driver > but FWIW: > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Matt Ranostay @Intel is the person you probably want to ACK it though, > he added the humidity calculations :)
It just turned out that there must be another error in the calculation. I'll fix and test it first.
When i'm done i'll send a new version of the patch.
Andreas
> > Yours, > Linus Walleij
--
| |