lkml.org 
[lkml]   [2017]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation
    On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote:
    > On 27/03/17 11:06, Andreas Klinger wrote:
    >> While calculating the compensation of the humidity there are negative
    >> values interpreted as unsigned because of unsigned variables used.
    >> These values need to be casted to signed as indicated by the documentation
    >> of the sensor.
    >>
    >> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
    >
    > Looks superficially right to me, but would like an Ack from Linus Walleij.

    I didn't work on these calculations, only infrastructure for the driver
    but FWIW:
    Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Matt Ranostay @Intel is the person you probably want to ACK it though,
    he added the humidity calculations :)

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2017-04-02 16:56    [W:5.015 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site