Messages in this thread | | | Date | Tue, 11 Apr 2017 19:10:22 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 |
| |
On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: > Russell King - ARM Linux <linux@armlinux.org.uk> writes: > > > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: > >> v5: Move register definitions inside the driver directory, fix build > >> in COMPILE_TEST and !AMBA mode. > > > > Why is it necessary to move the register definitions there, when > > they're already available in linux/amba/clcd.h and are required > > for the FB driver? > > > > It is absurd to have driver specific register definitions. > > Because after v2, v3, and v4, I still didn't have an ack on the patch to > move the register definitions from linux/amba/clcd.h to > linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd reuse > them.
I don't remember seeing such a patch, sorry.
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
| |