lkml.org 
[lkml]   [2017]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111
Date
Russell King - ARM Linux <linux@armlinux.org.uk> writes:

> On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote:
>> v5: Move register definitions inside the driver directory, fix build
>> in COMPILE_TEST and !AMBA mode.
>
> Why is it necessary to move the register definitions there, when
> they're already available in linux/amba/clcd.h and are required
> for the FB driver?
>
> It is absurd to have driver specific register definitions.

Because after v2, v3, and v4, I still didn't have an ack on the patch to
move the register definitions from linux/amba/clcd.h to
linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd reuse
them.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-04-11 18:06    [W:0.183 / U:3.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site