Messages in this thread | | | Subject | Re: block/sed-opal.c: 2 * bad if tests ? | From | Jon Derrick <> | Date | Mon, 6 Mar 2017 08:19:33 -0700 |
| |
On 03/06/2017 05:00 AM, David Binderman wrote: > Hello there, > > 1. > > block/sed-opal.c:2136:40: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] > > Source code is > > if (lk_unlk->session.who < OPAL_USER1 && > lk_unlk->session.who > OPAL_USER9) { > > 2. > > block/sed-opal.c:2319:37: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] > > if (opal_session->who < OPAL_USER1 && > opal_session->who > OPAL_USER9) { > > Duplicate. > > Also in the same file: > > [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used. > > Regards > > David Binderman > Thanks for the catch(es). Will provide patch shortly
| |