lkml.org 
[lkml]   [2017]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: block/sed-opal.c: 2 * bad if tests ?
From
Date
On 03/06/2017 05:00 AM, David Binderman wrote:
> Hello there,
>
> 1.
>
> block/sed-opal.c:2136:40: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> Source code is
>
> if (lk_unlk->session.who < OPAL_USER1 &&
> lk_unlk->session.who > OPAL_USER9) {
>
> 2.
>
> block/sed-opal.c:2319:37: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> if (opal_session->who < OPAL_USER1 &&
> opal_session->who > OPAL_USER9) {
>
> Duplicate.
>
> Also in the same file:
>
> [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used.
>
> Regards
>
> David Binderman
>
Thanks for the catch(es). Will provide patch shortly

\
 
 \ /
  Last update: 2017-03-06 16:22    [W:0.018 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site