Messages in this thread | | | Subject | Re: [PATCH v2 2/2] ARM: dts: sun7i: Add CAN node and can0_pins_a pinctrl settings | From | Patrick Menschel <> | Date | Fri, 31 Mar 2017 18:51:38 +0200 |
| |
Hello Maxime,
Am 27.03.2017 um 08:46 schrieb Maxime Ripard: >> @@ -1582,6 +1587,14 @@ >> #size-cells = <0>; >> }; >> >> + can0: can@01c2bc00 { >> + compatible = "allwinner,sun4i-a10-can"; > > Sorry for not spotting this earlier, but this would need an A20 > compatible too, to deal with the case where it turns out not to be > compatible. > > you can do something like this: > compatible = "allwinner,sun7i-a20-can", "allwinner,sun4i-a10-can";
Adding "sun7i-a20-can" to the compatible list results in a checkpatch warning, that the "driver" is not documented.
WARNING: DT compatible string "allwinner,sun7i-a20-can" appears un-documented -- check ./Documentation/devicetree/bindings/ #27: FILE: arch/arm/boot/dts/sun7i-a20.dtsi:1586: + compatible = "allwinner,sun7i-a20-can",
Is it really OK to add a driver that doesn't exist yet?
Thanks, Patrick
[unhandled content-type:application/pkcs7-signature] | |