[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[v2 PATCH 0/4] powernv:idle: Fixes for CPU-Hotplug on POWER DD1.0
From: "Gautham R. Shenoy" <>


This is the second version of the patchset containing the fixes to
make CPU-Hotplug working on correctly on POWER9 DD1 systems.

The earlier version of this patchset can be found here:

This patch addresses the feedback provided by Nicholas Piggin. The key
changes from the earlier version are:

- Move the piece of code in powernv/smp.c::pnv_smp_cpu_kill_self() which
transitions the CPU to the deepest available platform idle state to a
new function named pnv_cpu_offline() in powernv/idle.c. The rationale
behind this code movement is that the data required to determine the
deepest available platform state resides in powernv/idle.c.

- Adds a more descriptive warning describing the consequences of no
suitable default/deepest stop states being available.

- Update the commit log for "powernv:Recover correct PACA on wakeup
from a stop on P9 DD1" describing the problem that it is trying to
solve. Also ensure that on P9 DD1, NVGPRs are restored from the
stack on the way out by setting the NAPSTATELOST in paca.

I have retained Nicholas Piggin's Reviewed-by tag for the second patch
in this series (was first patch in the previous series) even though
the file containing the code is different.

There are four patches in the series.

- The first patch moves the platform-idle code invoked when a CPU offlined from powernv/smp.c to powernv/idle.c

- The second adds a fallback mechanism for CPU-Hotplug when no
platform idle state is available.

- The third patch ensures that the kernel doesn't use any stop state
that is not exposed by the firmware.

- The fourth patch adds a recovery framework for correctly recovering
paca pointer of the thread waking up from a stop.

These patches are based on v4.11-rc3.

The patches have been tested with stop1 (ESL=EC=1) as the
deepest-state entered into during CPU-Hotplug.

Gautham R. Shenoy (4):
powernv: Move CPU-Offline idle state invocation from smp.c to idle.c
powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug
powernv:idle: Don't override default/deepest directly in kernel
powernv: Recover correct PACA on wakeup from a stop on P9 DD1

arch/powerpc/include/asm/cpuidle.h | 1 +
arch/powerpc/include/asm/paca.h | 5 ++
arch/powerpc/kernel/asm-offsets.c | 1 +
arch/powerpc/kernel/idle_book3s.S | 49 +++++++++++++++++-
arch/powerpc/platforms/powernv/idle.c | 88 ++++++++++++++++++++++++++------
arch/powerpc/platforms/powernv/powernv.h | 2 -
arch/powerpc/platforms/powernv/smp.c | 18 +------
7 files changed, 129 insertions(+), 35 deletions(-)


 \ /
  Last update: 2017-03-20 16:57    [W:0.096 / U:6.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site