[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subjectz3fold: suspicious return with spinlock held

z3fold_reclaim_page() contains the only return that may
leave the function with pool->lock spinlock held.

669 spin_lock(&pool->lock);
670 if (kref_put(&zhdr->refcount, release_z3fold_page)) {
671 atomic64_dec(&pool->pages_nr);
672 return 0;
673 }

May be we need spin_unlock(&pool->lock); just before return?

Found by Linux Driver Verification project (

Thank you,
Alexey Khoroshilov
Linux Verification Center, ISPRAS

 \ /
  Last update: 2017-03-10 22:23    [W:0.042 / U:6.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site